Introduce and use the new "best effort" strategy for Secure Channel revoke checking #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The native Windows HTTPS backend is based on Secure Channel which lets the caller decide how to handle revocation checking problems caused by missing information in the certificate or offline CRL distribution points. Unfortunately, cURL chose to handle these problems differently than OpenSSL by default: while OpenSSL happily ignores those problems (essentially saying "¯\_(ツ)_/¯"), the Secure Channel backend will error out instead. As a remedy, the "no revoke" mode was introduced, which turns off revocation checking altogether. This is a bit heavy-handed. We support this via the `http.schannelCheckRevoke` setting. In curl/curl#4981, we contributed an opt-in "best effort" strategy that emulates what OpenSSL seems to do. In Git for Windows, we actually want this to be the default. This patch makes it so, introducing it as a new value for the `http.schannelCheckRevoke" setting, which now becmes a tristate: it accepts the values "false", "true" or "best-effort" (defaulting to the last one). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
schannel-revoke-best-effort
branch
from
f196072
to
19d37fd
Compare
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Mar 4, 2020
The native Windows HTTPS backend (Secure Channel) [has learned to work gracefully with Fiddler and corporate proxies](git-for-windows/git#2535). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 5, 2020
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 5, 2020
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 5, 2020
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 5, 2020
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
dscho
added a commit
that referenced
this pull request
Mar 6, 2020
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
dscho
added a commit
to dscho/git
that referenced
this pull request
Mar 6, 2020
…st-effort Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 6, 2020
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 9, 2020
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 9, 2020
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
dscho
added a commit
that referenced
this pull request
Mar 10, 2020
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 10, 2020
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
dscho
added a commit
that referenced
this pull request
Mar 10, 2020
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 22, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 22, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 23, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 23, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 24, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
dscho
added a commit
to microsoft/git
that referenced
this pull request
Apr 24, 2024
…st-effort Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 24, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
dscho
added a commit
that referenced
this pull request
Apr 25, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 25, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 25, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
dscho
added a commit
that referenced
this pull request
Apr 25, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 25, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 27, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 27, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 29, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 29, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
dscho
added a commit
to microsoft/git
that referenced
this pull request
Apr 29, 2024
…st-effort Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 29, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 29, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 4, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 4, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 9, 2024
Introduce and use the new "best effort" strategy for Secure Channel revoke checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We contributed a patch to cURL to silently ignore certain errors during revocation checking.
This should help the problems e.g. with Fiddler or with corporate proxies where it is relatively common that certificates are missing CRL distribution point URLs.
Since this seems to be what the OpenSSL backend does by default, we force this to be the default for the Secure Channel backend, too (and it can be overridden via
http.schannelCheckRevoke).cc @niik